Kopano Groupware Core
  1. Kopano Groupware Core

kopanocore

Public
AuthorCommitMessageCommit dateIssues
Jan EngelhardtJan Engelhardt
027a39788abMMerge branch 'kc-9.x'
Jan EngelhardtJan Engelhardt
ba85ad93c6cMMerge branch 'kc-8.7.x'
Jan EngelhardtJan Engelhardt
79106b731f8doc: update 8.7.x news
Joost HopmansJoost Hopmans
fe4154c4049MMerge pull request #2967 in KC/kopanocore from ~JVANDERWAA/kopanocore:php-ext-coverage to master* commit '07bfee8a8b9739c337d0015b673ed0a15884b9eb': php-ext: test: add more test cases for mapi_feature php-ext: add more server tests php-ext: remove unused zarafa_get_quota/zarafa_set_quota
Joost HopmansJoost Hopmans
7b6c598d4e3MMerge pull request #2973 in KC/kopanocore from ~JENGELHARDT/kc:ck8 to kc-8.7.x* commit '2d063a4d72161e6ff7f8db654d3b9aa8c02fdbc9': provider: cure potential null deref client: cure undefined behavior after GetProps libserver: avoid passing nullptr to memcmp libserver: abolish global writes after vfork common: export unix_popen_rw common: support requesting /dev/null fd with unix_popen_rw common: have unix_popen_rw support distinct stderr channel common: cl...
Joost HopmansJoost Hopmans
e6ed74064e1MMerge pull request #2970 in KC/kopanocore from ~JENGELHARDT/kc:ssl to kc-8.7.x* commit 'ca76d8044322c76456ee8d229d86842d54ee413f': common: update error messages for failed key/certfile loading build: adjust header lists for openssl
Joost HopmansJoost Hopmans
e459a82ea6dDockerfile.build: use latest dependencies hashUse the correct hash for retrieving the buildtime-dependencies-archive from download.kopano.io. The archive with the previous hash is no longer available.
Jan EngelhardtJan Engelhardt
2d063a4d721provider: cure potential null derefclang-9 reports: * (summary:) assuming int __size == -1, then for (unsigned int i = 0; i < size; ++i) will convert size to unsigned, which makes the loop run at least once, leading to a null deref.
Jan EngelhardtJan Engelhardt
bc236c444c8client: cure undefined behavior after GetProps
Jan EngelhardtJan Engelhardt
94192f3d359libserver: avoid passing nullptr to memcmpclang-9 reports: ECGenericObjectTable.cpp:1633-1641:38: warning: Null pointer passed as an argument to a "nonnull" parameter (ulPropType != PT_TSTRING && memcmp(lpSearchData, lpSearchString, ulSearchDataSize) == 0)) (ulPropType != PT_TSTRING && memcmp(lpSearchData, lpSearchString, ulSearchStringSize) == 0))
Joost HopmansJoost Hopmans
e8b1b9460e8MMerge pull request #2966 in KC/kopanocore from ~JENGELHARDT/kc:kc-1665 to kc-8.7.x* commit '1bf66d93b2d6de782b3267cabfcfdab75e7b24b1': fsck: consistent unique entity check
Jan EngelhardtJan Engelhardt
95b78ddf656libserver: abolish global writes after vforkclang-9 reports: ECSession.cpp:1231:14: warning: This assignment is prohibited after a successful vfork m_NTLM_pid = vfork(); [As both processes share memory after vfork, modifying global data is a bad idea.] ECSession.cpp:1231:16: warning: Call to function "vfork" is insecure as it can lead to denial of service situations in the parent process. Replace calls to vfork with calls to the safer...
Jan EngelhardtJan Engelhardt
0712b99868dcommon: export unix_popen_rw
Jan EngelhardtJan Engelhardt
a5f9e59a304common: support requesting /dev/null fd with unix_popen_rw
Jan EngelhardtJan Engelhardt
88193d91136common: have unix_popen_rw support distinct stderr channel
Jan EngelhardtJan Engelhardt
fd920b2107bcommon: close all unnecessary pipe fds in unix_popen_rwThe child started by posix_spawn would have all ends of the pipes still open, which can break EOF detection on the other end. [unix_system("", {"/bin/sleep", "60"}, nullptr) showed 7 open fds when it should have been just 3.]
Jan EngelhardtJan Engelhardt
01f61f252b8common: unbreak unix_popen_rw when parent has no fds 0-2A parent which has fds 0, 1, 2 already closed and then calls unix_system would fail to launch the process, as pipe() yields in={0, 1}, out={2, 3}, which the child would immediately close again due to addclose(&fa, STD*_FILENO) calls.
Jan EngelhardtJan Engelhardt
5d4e0fa04e2common: downgrade ec_relocate_fd warning severitySome utils run with standard user privileges, where the limit may well be 1024 already.
Jelle van der WaaJelle van der Waa
07bfee8a8b9php-ext: test: add more test cases for mapi_feature
Jelle van der WaaJelle van der Waa
c9048d70adaphp-ext: add more server testsExtend the server and unit tests to achieve 67% coverage for php-ext/main.cpp.
Jelle van der WaaJelle van der Waa
3bec0513898php-ext: remove unused zarafa_get_quota/zarafa_set_quotaNeither WebApp, WebAccess, Z-Push or anythinng on github uses these functions.
Jan EngelhardtJan Engelhardt
1bf66d93b2dfsck: consistent unique entity checkBy trivially concatenating the display name with the email address, two individual entities Foo <bar@baz.de> Fooba <r@baz.de> would be considered the same, even though they are not. This can be reproduced by creating an appointment, adding the two attendees to the invite list and then saving the appointment (without sending the invitation message). References: KC-1665KC-1665
Jan EngelhardtJan Engelhardt
8f581826279Kopano Groupware Core 10.0.1
Jan EngelhardtJan Engelhardt
775ebfa00d7MMerge branch 'kc-9.x'
Jan EngelhardtJan Engelhardt
c081ab26a9eKopano Groupware Core 9.0.3
Jan EngelhardtJan Engelhardt
372e72dc3c7libserver: fix ignored return value of GetSubRestrictionRecursive
Jan EngelhardtJan Engelhardt
33bfdaf0771libserver: fix plugin not receiving a stats collector objectclang-9 reports: ECPluginFactory.cpp:21:60: warning: Moved-from object "sc" is copied ECPluginSharedData::GetSingleton(&m_shareddata, m_config, sc, bHosted, bDistributed); Fixes: kopanocore-8.6.81-371-gb702ad305 References: KC-1263KC-1263
Jan EngelhardtJan Engelhardt
de36d36ba8flibserver: fix detection of old databasesclang-9 reported: ECDatabaseMySQL.cpp:780:5: warning: Value stored to "er" is never read Fixes: bp/8.3.0-763-g6d10d8404
Jan EngelhardtJan Engelhardt
e18f622d8c6kscriptrun: replace vfork by posix_spawnclang-9 has this to say: scriptrun.cpp:69:14: warning: Call to function "vfork" is insecure as it can lead to denial of service situations in the parent process. Replace calls to vfork with calls to the safer "posix_spawn" function auto ret = vfork();
Jan EngelhardtJan Engelhardt
c0d9e1abaccicalmapi: initialize unset variablesclang-9 reports: vconverter.cpp:100:8: warning: 3rd function call argument is an uninitialized value hr = HrAddException(lpEventRoot, lpEvent, bIsAllday, lpPrevItem); vconverter.cpp:2730:2: note: Returning [from HrRetrieveAlldayStatus] without writing to "*lpblIsAllday" vconverter.cpp:1139:9: warning: 6th function call argument is an uninitialized value return HrAddOrganizer(lpIcalItem, &lpIc...
Jan EngelhardtJan Engelhardt
022f62507abicalmapi: avoid potential UB deref in HrMakeMAPIRecurrenceWhen HrGetOneProp fails, prop may be left at a nullptr value. Alternatively, prop->ulPropTag may also be set to PROP_TAG(PT_ERROR, x), in which case access prop->Value.lpszW will dereference a garbage value.
Jan EngelhardtJan Engelhardt
e11b751568bm4lcommon: do not let HrCreateEmailSearchKey pass nullptr to memcpy
Jan EngelhardtJan Engelhardt
caecbe37d54m4lcommon: cure potential null deref on fnevSearchCompleteclang-9 --analyze warns: MAPINotifSink.cpp:41:11: warning: Dereference of null pointer (loaded from variable "lpCb")
Jan EngelhardtJan Engelhardt
ca76d804432common: update error messages for failed key/certfile loadingReferences: KF-2886, GH-PR-22KF-2886
Jan EngelhardtJan Engelhardt
89027ebfabebuild: adjust header lists for opensslReferences: KF-2886, GH-PR-21KF-2886
Jan EngelhardtJan Engelhardt
aac15f547aedoc: update 10.x news
Jan EngelhardtJan Engelhardt
6e158e7a001MMerge branch 'kc-9.x'
Jan EngelhardtJan Engelhardt
05ec2dbe6a7doc: update 9.x news
Jan EngelhardtJan Engelhardt
d7c1d708b95MMerge branch 'kc-8.7.x'
Jan EngelhardtJan Engelhardt
8e185bdb5dddoc: update 8.7.x news
Joost HopmansJoost Hopmans
80b732f29feMMerge pull request #2951 in KC/kopanocore from ~JENGELHARDT/kc:kc-1667 to kc-8.7.x* commit '36d8f99b52075936ec4e95c5f06e619a5d0ca92a': common: cure race condition near ECUnknown::Suicide client: add missing nullptr checks for m_lpCmd client: add missing reference tracking
Joost HopmansJoost Hopmans
61f2bace6a3MMerge pull request #2964 in KC/kopanocore from ~JENGELHARDT/kc:spello to kc-9.x* commit '8fca6339394d04d9b977a67adbb996bcd564e4ef': treewide: fix spellos
Joost HopmansJoost Hopmans
cdc8d02093cMMerge pull request #2962 in KC/kopanocore from ~JENGELHARDT/kc:icu to kc-8.7.x* commit '3f95678d213565f7bc9eba2531d2e67edff81a57': common: fix missing normalization in ustringutil functions common: add reason for using newlocale in str_ifind spooler: locale support during rule matching client: run table restrictions as per the locale mapi4linux: run table restrictions as per the locale
Joost HopmansJoost Hopmans
f76d8df5120MMerge pull request #2961 in KC/kopanocore from ~JENGELHARDT/kc:dnw to kc-8.7.x* commit '64a6371335f7bb6cf24d86205cef7028e3df1f75': storeadm: fix display_name JSON value key name
Joost HopmansJoost Hopmans
822fb4e2ee9MMerge pull request #2960 in KC/kopanocore from ~JENGELHARDT/kc:ssl to kc-8.7.x* commit 'f85fa3212bae284e24621d7718852138ad7ce47c': common: implement new-style OpenSSL 1.1+ SSL/TLS version setup common: implement new-style OpenSSL 1.1+ init/teardown for ECChannel common: remove useless ECChannel SSL_* calls and follow docs common: check whether ECChannel SSL context could be created common: normalize return value handling in ECChannel::HrSetCtx common: fix inc...
Joost HopmansJoost Hopmans
d81f27ae097MMerge pull request #2959 in KC/kopanocore from ~JENGELHARDT/kc:movs to master* commit '9cbd65d12bbd4f16d054411264286d4b5fc99896': libserver: have objectdetails_t::MergeFrom take rvalue ref libserver: add move version of SetPropString provider: add C++17 variants for objectdetails_t provider: replace .assign by operator=
Joost HopmansJoost Hopmans
6cc3dbfc9adMMerge pull request #2958 in KC/kopanocore from ~JENGELHARDT/kc:idn to master* commit '754802918e9ac45b2478b91e08be7e8962954368': libserver: support IDN searches in abResolveNames client: transform IDN to xn-style puny addresses build: search for libidn2 libserver: resolve hardcoded 0x8zzzzzzz values to mnemonics provider: resolve hardcoded 0x8zzzzzzz values to mnemonics
Joost HopmansJoost Hopmans
944780e9c10MMerge pull request #2956 in KC/kopanocore from ~JENGELHARDT/kc:stack to kc-8.7.x* commit '23f29a2a1da7690f71cd7c48db6fe5c789892962': programs: drop global exception handler
Jan EngelhardtJan Engelhardt
36d8f99b520common: cure race condition near ECUnknown::SuicideAfter "delete this", the memory location may be given to a new object, which can lead to a race with another thread's AddChild, for example such: // assume p->m_cRef = 2 (holders: T0, T1) T0: p->AddChild(p1); // p->m_lstChildren.size() == 1 T0: p->Release(); // p->m_cRef == 1 T0: c1->Release(); T0: ... (within c1->ECUnknown::Suicide) delete c1; T1: c2 = new Thing; // c2 == c1 T1: ...2 Jira Issues
Jelle van der WaaJelle van der Waa
3d939c3d0c0swig: tests: add server required unittestsThis is a partial port of the unittests which require an active kopano-server to operate and depends on three env variables to be set to use the test user/password and server.