Kopano Groupware Core
  1. Kopano Groupware Core

kopanocore

Public
AuthorCommitMessageCommit dateIssues
Joost HopmansJoost Hopmans
1ccdba538fcMPull request #3357: pyko: add test for store.licenseinfoMerge in KC/kopanocore from ~JVANDERWAA/kopanocore:pyko_licenseinfo_test to master * commit '86ecd06e2be9828c11e2323188c4861ddc414e62': pyko: add test for store.licenseinfo
Jelle van der WaaJelle van der Waa
86ecd06e2bepyko: add test for store.licenseinfo
Joost HopmansJoost Hopmans
4ac51b5a37aMPull request #3355: libserver: remove questionable rejection of different-term OR search requestsMerge in KC/kopanocore from ~JENGELHARDT/kc:kc-1385 to master * commit '064532ba0828c9f016a5876e574a41d438e332e9': libserver: remove questionable rejection of different-term OR search requests
Joost HopmansJoost Hopmans
32935dcac74MPull request #3359: CoverityMerge in KC/kopanocore from ~JENGELHARDT/kc:cov to master * commit '72f5eb47d49415f0a379fa68ef403776954e898d': treewide: declare ECMemStream::Seek return value for ignore common: drop return type for always-success functions of ECMemBlock libserver: add missing error handling for ECLicence_Auth callers inetmapi: cure Coverity warnings inetmapi: cure an std::string internal representa...
Jan EngelhardtJan Engelhardt
72f5eb47d49treewide: declare ECMemStream::Seek return value for ignoreCID-215525 (#1 of 1): Unchecked return value (CHECKED_RETURN) CID-215523 (#1 of 1): Unchecked return value (CHECKED_RETURN) 1. check_return: Calling Seek without checking return value (as is done elsewhere 8 out of 10 times). When seek to zero fails (IStream API), there is nothing meaningful to do about it. In practice, the only time that I can imagine when this would happen is if the stream i...2 Jira Issues
Jan EngelhardtJan Engelhardt
db9c01318eecommon: drop return type for always-success functions of ECMemBlock
Jan EngelhardtJan Engelhardt
8ea80de02c3libserver: add missing error handling for ECLicence_Auth callersCID-215521 (#1 of 1): Unused value (UNUSED_VALUE) CID-215524 (#1 of 1): Unused value (UNUSED_VALUE) returned_value: Assigning value from ECLicense_Auth() to er here, but that stored value is overwritten before it can be used. Fixes: kopanocore-10.0.6-497-gdda3f47ed References: KC-18213 Jira Issues
Jan EngelhardtJan Engelhardt
8fb55cd2bb9inetmapi: cure Coverity warningsCID-157468 (#1 of 1): Wrapper object use after free (WRAPPER_ESCAPE) CID-157463 (#1 of 1): Wrapper object use after free (WRAPPER_ESCAPE) 20. escape: The internal representation of local strFromSearchKey escapes into msgProps[nProps++].Value.bin.lpb, but is destroyed when it exits scope.2 Jira Issues
Jan EngelhardtJan Engelhardt
7780e51e37binetmapi: cure an std::string internal representation escapeCID-157450 (#1 of 1): Wrapper object use after free (WRAPPER_ESCAPE) When the convertMAPIToVMIME call fails, sopt.alternative_boundary is not reset, hence the CID warning.CID-157450
Jan EngelhardtJan Engelhardt
a97da094c89dagent: treat each recipient's message copy as an individual entityIn a multi-recipient LMTP submission, inbox rules of the first recipient — read flags, categories — would affect the results for all following users. That is undesirable. (When postfix is set to default_destination_recipient_limit=1 (debug), this would never show, as every LMTP submit has just one recipient.) References: KS-46301, KC-18822 Jira Issues
Joost HopmansJoost Hopmans
c2c31b4f109MPull request #3356: Add 20127 codepage in the charset map listMerge in KC/kopanocore from ~MORTEZA/kopanocore:KC-1899 to master * commit '37edc2bb0842dd2a6e1ac081d7751f63d979dcea': Update the wrong code page 2012 to 20127KC-1899
Joost HopmansJoost Hopmans
0e35abccadcMPull request #3350: Support page_start and page_limit parameters on fetching root foldersMerge in KC/kopanocore from ~MORTEZA/kopanocore:KC-1893 to master * commit '254d732200dd4f6c8946babcbc465c43409b53b4': Support page_start and page_limit parameters on fetching root foldersKC-1893
Joost HopmansJoost Hopmans
bb1f8ebdc90MPull request #3354: build: drop indexd and requirement on dbMerge in KC/kopanocore from ~JENGELHARDT/kc:kc-1881 to master * commit '980b2fef7ec98a6d3946e857f7192d7c121443fd': build: drop indexd and requirement on db
Morteza NourelahiAlamdari Morteza NourelahiAlamdari
254d732200dSupport page_start and page_limit parameters on fetching root folders
Morteza NourelahiAlamdari Morteza NourelahiAlamdari
37edc2bb084Update the wrong code page 2012 to 20127
Jan EngelhardtJan Engelhardt
064532ba082libserver: remove questionable rejection of different-term OR search requestsReferences: KC-1385KC-1385
Jan EngelhardtJan Engelhardt
980b2fef7ecbuild: drop indexd and requirement on dbReferences: KC-1881KC-1881
Jan EngelhardtJan Engelhardt
ca465525171client: read JSON license block for SSO/OIDC logonsReferences: KC-1892KC-1892
Jan EngelhardtJan Engelhardt
a42936f97e4client: switch to WSTransport functions to HRESULT return type
Jan EngelhardtJan Engelhardt
488353dc7f9client: factor out JSON license block extraction from HrLogon2
Jan EngelhardtJan Engelhardt
52649d3a84cclient: add server version reporting for OIDC logon
Jan EngelhardtJan Engelhardt
d9cea64d66cclient: make OIDCLogon error reporting behave the same as SSOLogon
Jan EngelhardtJan Engelhardt
c38d4f2e1feclient: add server version reporting for SSO logonThe server reports its own version to the client upon logon. This information, though received from the network, was never stored in a variable for the generic client, but only the Win32 client (which was removed in commit bp/8.0.1-4-g48d4075f0).
Jan EngelhardtJan Engelhardt
7d80b4636efclient: remove obsolete comment about non-const ParseKopanoVersionParseZarafaVersion had a const-ref argument for as long as can be remembered.
Jan EngelhardtJan Engelhardt
c30e0ed7484client: trim unused ParseKopanoVersion result variable
Joost HopmansJoost Hopmans
f414a5a70feMPull request #3294: use vector<> for objectid lists 2Merge in KC/kopanocore from ~JENGELHARDT/kc:objvec to master * commit 'dd9fd99c0c99d658e2fc251e11d56b61f6fc815e': treewide: include <utility> for std::move treewide: include <iterator> for std::back_inserter libserver: algorithmize object id copies libserver: use std::vector for GenericObjectTable objids (2)
Jan EngelhardtJan Engelhardt
dd9fd99c0c9treewide: include <utility> for std::move
Jan EngelhardtJan Engelhardt
871467c4525treewide: include <iterator> for std::back_inserter
Jan EngelhardtJan Engelhardt
e3550587cdflibserver: algorithmize object id copies
Jan EngelhardtJan Engelhardt
648f1b0a9delibserver: use std::vector for GenericObjectTable objids (2)list<int> has an overhead of 20 bytes per integer on amd64-linux-g++, and it is also not very cache-friendly for traversal.
Jelle van der WaaJelle van der Waa
2e089c3d133Add missing gitignore for new dagent tests
Joost HopmansJoost Hopmans
83796b4175dMPull request #3296: Dagent testsMerge in KC/kopanocore from ~JVANDERWAA/kopanocore:dagent_tests to master * commit '1445877d7972511b727a42edd300c15eaec350a0': pyko: tests: simply __str__ test pyko: tests: fix server.options in test_storefilter pyko: tests: remove print() gateway: cleanup created messages from imap test spooler: add dagent unit tests pyko: bump the timeout of notification tests Add a general tim...
Joost HopmansJoost Hopmans
13fd38863fbMPull request #3346: Fix multiple crashesMerge in KC/kopanocore from ~JENGELHARDT/kc:alpine to master * commit 'e0a19de61bd4263b61c6739cf547c1d71092635b': common: cure crash when ec_socket calls freeaddrinfo common: cure a move error in ec_bindspec_to_sockets common: avoid taking a socket twice from env common: make convert_to survive without GNU extensions client: cure musl header inclusion warning build: avoid building ...
Jan EngelhardtJan Engelhardt
e0a19de61bdcommon: cure crash when ec_socket calls freeaddrinfofreeaddrinfo can only be used with getaddrinfo, but there is a custom allocation inside ec_socket. References: KF-3361, KC-18892 Jira Issues
Joost HopmansJoost Hopmans
a4501ad2df8MPull request #3338: Fix code compatibility to support Python 3.6+Merge in KC/kopanocore from ~MORTEZA/kopanocore:KC-1875 to master * commit '302ddaf9831c1aad4dade763a5c8a8e70306714e': Fix code compatibility to support Python 3.6+KC-1875
Jan EngelhardtJan Engelhardt
3cffe19b302common: cure a move error in ec_bindspec_to_sockets"spec" is used in a ec_log call after moved away into ec_bindspec_to_socket, which constitutes a logical error / can cause garbage to be printed. References: KF-3361KF-3361
Jan EngelhardtJan Engelhardt
cd5cbc8977dcommon: avoid taking a socket twice from envReferences: KF-3361KF-3361
Jan EngelhardtJan Engelhardt
ab62626c8d4common: make convert_to survive without GNU extensionsReferences: KF-3361KF-3361
Jan EngelhardtJan Engelhardt
dbd85231a78client: cure musl header inclusion warningIn file included from ECNotifyMaster.cpp:18: /usr/include/sys/signal.h:1:2: warning: #warning redirecting incorrect "#include <sys/signal.h>" to "<signal.h>" [-Wcpp] References: KF-3361KF-3361
Jan EngelhardtJan Engelhardt
07d869d6f4cbuild: avoid building mapi.la when ./configure --without-phpReferences: KF-3361KF-3361
Jan EngelhardtJan Engelhardt
579d7316b4dcommon: use std::string for constructing forceUTF8Locale's new localeReferences: KF-3361KF-3361
Jan EngelhardtJan Engelhardt
1352f921e79common: replace forceUTF8Locale's use of strncpystrncpy could leave the output buffer without a \0 if the input was large enough. References: KF-3361KF-3361
Noel KuntzeJan EngelhardtNoel Kuntze
993fa98d99ccommon: heed setlocale's return value being defined immutableOperate on stack instead of returned pointer in forceUTF8Locale. [POSIX.1-2017 says """The application shall not modify the string returned."""] References: KF-3361KF-3361
Jan EngelhardtJan Engelhardt
9ef14771f07build: support XSI strerror_rUnixUserPlugin.cpp: In member function 'void UnixUserPlugin::errnoCheck(const string&, int) const': UnixUserPlugin.cpp:920:77: error: no match for 'operator+' (operand types are 'std::__cxx11::basic_string<char>' and 'int') 920 | throw std::runtime_error("unable to query for user " + user + ". Error: " + retbuf); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...KF-3361
Jan EngelhardtJan Engelhardt
2e37420f2ecunixplugin: drop use of getpwent_rUnixUserPlugin.cpp:355:7: error: "getpwent_r" was not declared in this scope; did you mean "getpwent"? There is not a lot of sense in getpwent_r. Though it avoids the use of a singleton buffer, it still operates on a singleton iterator that is used to walk the NSS database. References: KF-3361KF-3361
Jan EngelhardtJan Engelhardt
ffeb300d9a3libserver: wrap pthread_getname_nppthread_getname_np is supposed to be wrapped in ifdef, just like in common/ECLogger.cpp. References: KF-3361KF-3361
Jan EngelhardtJan Engelhardt
5facca7ddcephp-ext: replace __GNUC_PREREQ__GNUC_PREREQ is a thing only present in GNU libc. Replace it by native GCC-provided macro/identifiers. Fixes: bp/8.2.0-523-gc70e9c74f References: KF-3361KF-3361
Jan EngelhardtJan Engelhardt
77d22ff589flibserver: replace call to potentially absent pthread_yieldpthread_yield is not available in musl. It is also a suboptimal choice to delay execution as a whole, so replace it by something more adequate. References: KF-3361KF-3361
Jan EngelhardtJan Engelhardt
91c385ba764build: fix build failure with libintlIf the GNU gettext implementation of gettext functions is used instead of the GNU libc implementation of gettext functions, there is a link error. This is because INTL_LIBS stays empty when it should not. /usr/x86_64-alpine-linux-musl/bin/ld: .libs/libkcutil.so: undefined reference to "libintl_bind_textdomain_codeset" undefined reference to "libintl_dcgettext" References: KF-3361KF-3361
Jan EngelhardtJan Engelhardt
87ec1c00471build: fix build failure when curl is absentcommon/StatsClient.cpp:67:31: error: "CURL" was not declared in this scope 67 | static bool sc_proxy_from_env(CURL *ch, const char *url) common/StatsClient.cpp: In member function "std::string KC::ECStatsCollector::stats_as_text()": common/StatsClient.cpp:144:3: error: "setleaf" was not declared in this scope 144 | setleaf(leaf, i.second); References: KF-3361KF-3361